I use these for rock climbing and Crossfit workouts. The length is good for climbing, especially when wearing a harness. The shorts are a traditional fit, not fitted or contoured, and the material has plenty stretch allowing ample range of motion.
These shorts don't have pockets in the traditional pocket location, therefore there is no interference with a climbing harness or barbell. However, pockets in the traditional locations are very convenient and can be designed to minimize interference, see Salomon Float shorts. So I took 1 star for that.
I'm 5'11" 152lbs and normally wear a 30in waist. The 30 in these shorts is slightly too big for me; it's a very generous 30in waist. I believe I could fit into the 28. The drawstring is adequate though, I'll be keeping them.